GTK: Port RenderWidgetHostViewGtk to latest GTK

GTK: Port RenderWidgetHostViewGtk to latest GTK

New API used:

gtk_widget_get_window - replaces direct access
gtk_widget_get_allocation - added in 2.18 - replaces direct access
gdk_window_get_width / gdk_window_get_height added in 2.24 - replaces
deprecated gdk_window_get_size so is added to ui/base/gtk/gtk_compat.h

With these changes the file can be compiled with sealed structures and
deprecated API disabled with the exception of the deprecated function
gdk_bitmap_create_from_data used in the cursor creation. That will come in a
separate change.

BUG=79722
TEST=Compiles and chrome runs


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112498

[Elliot Glaysher, 2011-11-28 18:35:42]

http://codereview.chromium.org/8635018/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_widget_host_view_gtk.cc (right):

http://codereview.chromium.org/8635018/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_gtk.cc:1390: window_w =
gdk_window_get_width(window);
nit: we aren't using c here; it's ok to compress this to gint window_w =
gdk_window_get_width.

http://codereview.chromium.org/8635018/diff/1/ui/base/gtk/gtk_compat.h
File ui/base/gtk/gtk_compat.h (right):

http://codereview.chromium.org/8635018/diff/1/ui/base/gtk/gtk_compat.h#newcode30
ui/base/gtk/gtk_compat.h:30: inline gint gdk_visual_get_depth(GdkVisual* visual)
{
Please keep the GTK_CHECK_VERSION sections in order. 18 should come before 20.

http://codereview.chromium.org/8635018/diff/1/ui/base/gtk/gtk_compat.h#newcode44
ui/base/gtk/gtk_compat.h:44: inline int gdk_window_get_width(GdkWindow* window)
Remove whitespace and match bracing style. add default values for width, height.
also the alphabetical order for these functions should be:

gdk_window_get_height
gdk_window_get_screen
gdk_window_get_width

[robert.bradford, 2011-11-29 12:02:49]

Thanks for the patient review - i'm new to this coding style. I've got
cpplint.py now.

http://codereview.chromium.org/8635018/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_widget_host_view_gtk.cc (right):

http://codereview.chromium.org/8635018/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_gtk.cc:1390: window_w =
gdk_window_get_width(window);
On 2011/11/28 18:35:42, Elliot Glaysher wrote:
> nit: we aren't using c here; it's ok to compress this to gint window_w =
> gdk_window_get_width.

Done and similarly for window_h too.

http://codereview.chromium.org/8635018/diff/1/ui/base/gtk/gtk_compat.h
File ui/base/gtk/gtk_compat.h (right):

http://codereview.chromium.org/8635018/diff/1/ui/base/gtk/gtk_compat.h#newcode30
ui/base/gtk/gtk_compat.h:30: inline gint gdk_visual_get_depth(GdkVisual* visual)
{
On 2011/11/28 18:35:42, Elliot Glaysher wrote:
> Please keep the GTK_CHECK_VERSION sections in order. 18 should come before 20.

Done.

http://codereview.chromium.org/8635018/diff/1/ui/base/gtk/gtk_compat.h#newcode44
ui/base/gtk/gtk_compat.h:44: inline int gdk_window_get_width(GdkWindow* window)
On 2011/11/28 18:35:42, Elliot Glaysher wrote:
> Remove whitespace and match bracing style. add default values for width,
height.
> also the alphabetical order for these functions should be:
> 
> gdk_window_get_height
> gdk_window_get_screen
> gdk_window_get_width

Done.

[commit-bot: I haz the power, 2011-11-29 21:44:45]

No LGTM from valid reviewers yet.

[Elliot Glaysher, 2011-11-29 21:45:28]

lgtm

[commit-bot: I haz the power, 2011-11-29 21:45:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.bradford@intel.com/8635018/6001

[commit-bot: I haz the power, 2011-11-29 21:45:47]

Presubmit check for 8635018-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/renderer_host/render_widget_host_view_gtk.cc

[Elliot Glaysher, 2011-11-29 21:47:16]

jam: Please OWNERS stamp this patch.

[jam, 2011-11-30 18:46:31]

lgtm

[commit-bot: I haz the power, 2011-11-30 18:47:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.bradford@intel.com/8635018/6001

[commit-bot: I haz the power, 2011-11-30 19:12:36]

Try job failure for 8635018-6001 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[robert.bradford, 2011-12-01 10:34:47]

Turns out my 2.18 build environment wasn't actually 2.18 :-) so I missed out
both an include issue and that gdk_visual_get_depth was added in 2.22.

[commit-bot: I haz the power, 2011-12-01 17:32:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.bradford@intel.com/8635018/15001

[commit-bot: I haz the power, 2011-12-01 19:54:59]

Change committed as 112498