Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 8635013: Adds new strings for the media stream infobar. "Allow" and "Deny" strings were (Closed)

Created:
9 years, 1 month ago by macourteau
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adds new strings for the media stream infobar. "Allow" and "Deny" strings were left there because 1) that's how it's done everywhere else, 2) there are no generic versions of it and 3) the translation to other languages might be dependent on the context. BUG=105115 TEST=No user visible changes.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +27 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
macourteau
Hi guys, Forgot to send the mail... PTAL when you have a few minutes! Thanks, ...
9 years, 1 month ago (2011-11-23 21:57:34 UTC) #1
Peter Kasting
LGTM, although I kinda think we ought to refactor some of the other "allow/deny" cases ...
9 years, 1 month ago (2011-11-23 23:01:17 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm I don't think you should refactor some of the other "allow/deny" cases to create ...
9 years, 1 month ago (2011-11-24 14:30:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/macourteau@chromium.org/8635013/1
9 years, 1 month ago (2011-11-24 14:35:32 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 16:25:35 UTC) #5
Change committed as 111538

Powered by Google App Engine
This is Rietveld 408576698