Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 8635012: [cros] Fix crash in StubLogin. (Closed)

Created:
9 years, 1 month ago by Ivan Korotkov
Modified:
9 years, 1 month ago
Reviewers:
whywhat
CC:
chromium-reviews
Visibility:
Public.

Description

[cros] Fix crash in StubLogin. Crash happened due to ParallelAuthenticator calling StubLogin::OnLoginSuccess twice. BUG=None TEST=Manual: browser shouldn't crash when started with both --login-user and --login-password. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M chrome/browser/chrome_browser_main.cc View 2 chunks +21 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Korotkov
PTAL
9 years, 1 month ago (2011-11-22 16:51:54 UTC) #1
whywhat
lgtm
9 years, 1 month ago (2011-11-22 17:16:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/8635012/1
9 years, 1 month ago (2011-11-22 18:19:57 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 19:48:02 UTC) #4
Change committed as 111195

Powered by Google App Engine
This is Rietveld 408576698