Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/api.cc

Issue 8635011: Introduce short external strings without pointer cache. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap.h » ('j') | src/ia32/codegen-ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 1a47e096fb7b097a9eae7f7d0351feebbd15198d..9710fa858614f9ca6a7525f4fadd323339e5d7c6 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -4560,7 +4560,7 @@ bool v8::String::CanMakeExternal() {
return false;
}
int size = obj->Size(); // Byte size of the original string.
- if (size < i::ExternalString::kSize)
+ if (size < i::ExternalString::kShortSize)
Lasse Reichstein 2011/11/23 08:43:20 Put braces around the then-statement.
Yang 2011/11/23 09:58:48 Done.
return false;
i::StringShape shape(*obj);
return !shape.IsExternal();
« no previous file with comments | « no previous file | src/heap.h » ('j') | src/ia32/codegen-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698