Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: ui/base/x/events_x.cc

Issue 8634009: aura: Turn XInput2 back on. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/desktop_host_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/x/events_x.cc
diff --git a/ui/base/x/events_x.cc b/ui/base/x/events_x.cc
index 06adb00c37d2620caf5889573d236d70dd6e08fa..2c38267b45f9cad0ae87d9d22aa175592e0a898b 100644
--- a/ui/base/x/events_x.cc
+++ b/ui/base/x/events_x.cc
@@ -256,8 +256,26 @@ gfx::Point EventLocationFromNative(const base::NativeEvent& native_event) {
case GenericEvent: {
XIDeviceEvent* xievent =
static_cast<XIDeviceEvent*>(native_event->xcookie.data);
- return gfx::Point(static_cast<int>(xievent->event_x),
- static_cast<int>(xievent->event_y));
+
+ // Read the position from the valuators, because the location reported in
+ // event_x/event_y seems to be different (and doesn't match for events
+ // coming from slave device and master device) from the values in the
+ // valuators. See more on crbug.com/103981. The position in the valuators
+ // is in the global screen coordinates. But it is necessary to convert it
+ // into the window's coordinates. If the valuator is not set, that means
+ // the value hasn't changed, and so we can use the value from
+ // event_x/event_y (which are in the window's coordinates).
+ double* valuators = xievent->valuators.values;
+
+ double x = xievent->event_x;
+ if (XIMaskIsSet(xievent->valuators.mask, 0))
+ x = *valuators++ - (xievent->root_x - xievent->event_x);
+
+ double y = xievent->event_y;
+ if (XIMaskIsSet(xievent->valuators.mask, 1))
+ y = *valuators++ - (xievent->root_y - xievent->event_y);
+
+ return gfx::Point(static_cast<int>(x), static_cast<int>(y));
}
}
return gfx::Point();
« no previous file with comments | « ui/aura/desktop_host_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698