Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 8634008: Adding parameter to GetStatusLabels to indicate if links are acceptable. (Re applied) (Closed)

Created:
9 years, 1 month ago by jimblackler
Modified:
9 years ago
Reviewers:
akalin
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), Paweł Hajdan Jr.
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Re-application of CL originally reviewed here: http://codereview.chromium.org/8383036 That CL was wound back after test failures not caught by commitbot. Those test failures fixed here. Adding parameter to GetStatusLabels to indicate if links are acceptable, as some platforms cannot handle links in all the places these messages are shown." This reverts commit 8a7d864f6069576f60bc9a63b9916d86a6157f96. BUG=N/A TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112194

Patch Set 1 #

Patch Set 2 : Test fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -24 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/sync_global_error_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.h View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 6 chunks +24 lines, -10 lines 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 1 6 chunks +215 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jimblackler
9 years, 1 month ago (2011-11-22 16:09:22 UTC) #1
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 1 month ago (2011-11-23 13:23:07 UTC) #2
jimblackler
Fred, would you mind re-reviewing this (following the rollback and fix).
9 years, 1 month ago (2011-11-23 13:43:44 UTC) #3
akalin
On 2011/11/23 13:43:44, jimblackler wrote: > Fred, would you mind re-reviewing this (following the rollback ...
9 years ago (2011-11-29 17:35:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jimblackler@google.com/8634008/3001
9 years ago (2011-11-30 09:45:57 UTC) #5
commit-bot: I haz the power
9 years ago (2011-11-30 11:03:36 UTC) #6
Change committed as 112194

Powered by Google App Engine
This is Rietveld 408576698