Issue 8634007: [cros] Users without no profile image get a gray avatar when Local State is loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8634007: [cros] Users without no profile image get a gray avatar when Local State is loaded. (Closed)

Created:
9 years, 1 month ago by Ivan Korotkov

Modified:
9 years, 1 month ago

Reviewers:
whywhat

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] Users without no profile image get a gray avatar when Local State is loaded. BUG=chromium-os:23210 TEST=Manual: on the Login screen, users who selected profile image but don't have one should be displayed with a gray avatar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111160

Patch Set 1 #

Total comments: 2

Patch Set 2 : Same stub image for external and profile images. #

Patch Set 3 : Compile error fix. #

Patch Set 4 : Merge #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	chrome/browser/chromeos/login/user_manager.cc	View	1 2 3	3 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

whywhat

lgtm http://codereview.chromium.org/8634007/diff/1/chrome/browser/chromeos/login/user_manager.cc File chrome/browser/chromeos/login/user_manager.cc (right): http://codereview.chromium.org/8634007/diff/1/chrome/browser/chromeos/login/user_manager.cc#newcode617 chrome/browser/chromeos/login/user_manager.cc:617: // Until image has been loaded, use the ...

9 years, 1 month ago (2011-11-22 13:55:39 UTC) #2

Ivan Korotkov

9 years, 1 month ago (2011-11-22 15:11:07 UTC) #3

http://codereview.chromium.org/8634007/diff/1/chrome/browser/chromeos/login/u...
File chrome/browser/chromeos/login/user_manager.cc (right):

http://codereview.chromium.org/8634007/diff/1/chrome/browser/chromeos/login/u...
chrome/browser/chromeos/login/user_manager.cc:617: // Until image has been
loaded, use the default gray avatar.
On 2011/11/22 13:55:39, whywhat wrote:
> Let's use gray avatar in both cases.

Makes sense.

Expand Messages | Collapse Messages