Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 8633021: Don't reload the keyboard on clean exit. (Closed)

Created:
9 years, 1 month ago by bryeung
Modified:
9 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews
Visibility:
Public.

Description

Don't reload the keyboard on clean exit. BUG=none TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111235

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bryeung
9 years, 1 month ago (2011-11-22 19:46:50 UTC) #1
sadrul
Nice. LGTM http://codereview.chromium.org/8633021/diff/1/chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc File chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc (right): http://codereview.chromium.org/8633021/diff/1/chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc#newcode9 chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc:9: #include "chrome/browser/browser_process.h" Probably don't need this include.
9 years, 1 month ago (2011-11-22 20:22:18 UTC) #2
bryeung
On 2011/11/22 20:22:18, sadrul wrote: > Nice. LGTM > > http://codereview.chromium.org/8633021/diff/1/chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc > File chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc (right): ...
9 years, 1 month ago (2011-11-22 20:25:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryeung@chromium.org/8633021/3001
9 years, 1 month ago (2011-11-22 20:30:42 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 22:26:18 UTC) #5
Change committed as 111235

Powered by Google App Engine
This is Rietveld 408576698