Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 8633015: Allow initializing a field in a superclass in a const constructor. (Closed)

Created:
9 years, 1 month ago by zundel
Modified:
9 years ago
Reviewers:
codefu
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow initializing a field in a superclass in a const constructor. BUG=360

Patch Set 1 : New unit test fails on vm #

Patch Set 2 : Fixes to lookupField #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -1 line) Patch
M compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java View 1 1 chunk +27 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 1 chunk +4 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 1 chunk +45 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/src/ConstConstructorTest.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
9 years, 1 month ago (2011-11-22 15:54:43 UTC) #1
zundel
9 years ago (2011-11-30 15:41:45 UTC) #2
Closing this issue uncommitted.

It turns out, this is not allowed in Dart, as per Gilad's comments at:

http://code.google.com/p/dart/issues/detail?id=556

Powered by Google App Engine
This is Rietveld 408576698