Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: tools/valgrind/drmemory_analyze.py

Issue 8633013: Simplify drmemory_analyze and remove some unneeded stuff (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/drmemory_analyze.py
===================================================================
--- tools/valgrind/drmemory_analyze.py (revision 111138)
+++ tools/valgrind/drmemory_analyze.py (working copy)
@@ -42,7 +42,6 @@
def ReadLine(self):
self.line_ = self.cur_fd_.readline()
- self.stack_trace_line_ = None
Timur Iskhodzhanov 2011/11/22 13:08:28 not needed, too much copy-paste from the TSan/Mac
def ReadSection(self):
result = [self.line_]
@@ -58,22 +57,13 @@
while True:
self.ReadLine()
if (self.line_ == ''): break
- if re.search("FINAL SUMMARY:", self.line_):
- # No more reports since this point.
- break
- tmp = []
+
match = re.search("^Error #[0-9]+: (.*)", self.line_)
if match:
self.line_ = match.groups()[0].strip() + "\n"
- tmp.extend(self.ReadSection())
+ tmp = self.ReadSection()
self.reports.append(tmp)
- elif self.line_.startswith("ASSERT FAILURE"):
- self.reports.append(self.line_.strip())
- while True:
- self.ReadLine();
- if (self.line_ == ''): break
-
if re.search("SUPPRESSIONS USED:", self.line_):
self.ReadLine()
while self.line_.strip() != "":
@@ -82,12 +72,7 @@
line).groups()
self.used_suppressions.append("%7s %s" % (count, name))
self.ReadLine()
- break
- while True:
- self.ReadLine();
- if (self.line_ == ''): break
-
if self.line_.startswith("ASSERT FAILURE"):
self.reports.append(self.line_.strip())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698