Issue 8633013: Simplify drmemory_analyze and remove some unneeded stuff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8633013: Simplify drmemory_analyze and remove some unneeded stuff (Closed)

Created:
9 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 1 month ago

Reviewers:
Derek Bruening

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Reid Kleckner

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Simplify drmemory_analyze and remove some unneeded stuff TBR=bruening Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111140

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -17 lines)			Patch
	M	tools/valgrind/drmemory_analyze.py	View		3 chunks	+2 lines, -17 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

TBR Now the bots should print out the list of suppressions again. http://codereview.chromium.org/8633013/diff/1/tools/valgrind/drmemory_analyze.py File tools/valgrind/drmemory_analyze.py ...

9 years, 1 month ago (2011-11-22 13:08:28 UTC) #1

Derek Bruening

9 years, 1 month ago (2011-11-22 17:06:16 UTC) #2

Confusing b/c this diff was sent earlier yet seems to be after
http://codereview.chromium.org/8638010/ was committed.

Anyway LGTM.

Expand Messages | Collapse Messages