Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 8633012: [cros] Return proxy-settings back to the network menu list for OOBE. (Closed)

Created:
9 years, 1 month ago by altimofeev
Modified:
9 years, 1 month ago
CC:
chromium-reviews, dcheng, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[cros] Return proxy-settings back to the network menu list for OOBE. Also distinguish cases when network dropdown is shown on an OOBE screen and when not. BUG=chromium-os:22891 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111539

Patch Set 1 #

Patch Set 2 : merged #

Patch Set 3 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -25 lines) Patch
M chrome/browser/chromeos/status/network_menu.cc View 1 2 1 chunk +10 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/login/network_dropdown.js View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_network.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_error_message.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
altimofeev
Charlie: network menu part. Also notice, that this CL reverts a part of your previous ...
9 years, 1 month ago (2011-11-22 12:23:47 UTC) #1
Nikita (slow)
lgtm
9 years, 1 month ago (2011-11-22 15:38:23 UTC) #2
Charlie Lee
lgtm lgtm
9 years, 1 month ago (2011-11-22 18:40:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/altimofeev@chromium.org/8633012/1
9 years, 1 month ago (2011-11-23 07:55:01 UTC) #4
commit-bot: I haz the power
Presubmit check for 8633012-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-23 07:55:05 UTC) #5
altimofeev
Steven: owner approval needed for "chrome/browser/chromeos/status/*". Erik: owner approval needed for "chrome/browser/resources/chromeos/login/*"
9 years, 1 month ago (2011-11-23 08:02:36 UTC) #6
stevenjb
Awaiting comments on the issue: http://code.google.com/p/chromium-os/issues/detail?id=22891
9 years, 1 month ago (2011-11-23 20:23:56 UTC) #7
stevenjb
network_menu changes lgtm
9 years, 1 month ago (2011-11-23 23:18:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/altimofeev@chromium.org/8633012/1
9 years, 1 month ago (2011-11-24 14:45:22 UTC) #9
commit-bot: I haz the power
Can't apply patch for file chrome/browser/chromeos/status/network_menu.cc. While running patch -p1 --forward --force; patching file chrome/browser/chromeos/status/network_menu.cc ...
9 years, 1 month ago (2011-11-24 14:45:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/altimofeev@chromium.org/8633012/7001
9 years, 1 month ago (2011-11-24 14:56:21 UTC) #11
commit-bot: I haz the power
Can't apply patch for file chrome/browser/chromeos/status/network_menu.cc. While running patch -p1 --forward --force; patching file chrome/browser/chromeos/status/network_menu.cc ...
9 years, 1 month ago (2011-11-24 14:56:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/altimofeev@chromium.org/8633012/6003
9 years, 1 month ago (2011-11-24 15:38:27 UTC) #13
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 16:53:32 UTC) #14
Change committed as 111539

Powered by Google App Engine
This is Rietveld 408576698