Http Cache: Make sure that we don't switch to mode NONE when

Http Cache: Make sure that we don't switch to mode NONE when
StopCaching is called if there is no network transaction, or
the entry is sparse.

BUG=105041, 22900
TEST=net_unittests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111181

[gavinp, 2011-11-22 18:24:39]

LGTM

http://codereview.chromium.org/8633001/diff/1/net/http/http_cache_transaction.cc
File net/http/http_cache_transaction.cc (right):

http://codereview.chromium.org/8633001/diff/1/net/http/http_cache_transaction...
net/http/http_cache_transaction.cc:374: !is_sparse_ && !range_requested_)
So this is OK because downloads are never range_requested?

What happens if we get a resource cached sparsely for some use, then do a
download: will we still tickle bug 22900?

[rvargas (doing something else), 2011-11-22 18:35:03]

Thanks.

http://codereview.chromium.org/8633001/diff/1/net/http/http_cache_transaction.cc
File net/http/http_cache_transaction.cc (right):

http://codereview.chromium.org/8633001/diff/1/net/http/http_cache_transaction...
net/http/http_cache_transaction.cc:374: !is_sparse_ && !range_requested_)
Yes we will. 22900 is an optimization, so in this case we just don't optimize it
and default to double-saving.

On the other hand, this is not the only measure to avoid caching a download (not
even the main one, from my point of view). Any user-initiated download should
have the right LoadFlag from the beginning.

Note that a more common case is when we are resuming an interrupted fetch
(truncated flag). If we are reading from the cache (and that should be the
common case), then there's no network transaction yet, so we don't do anything.
That's in fact the crash I looked at.

On 2011/11/22 18:24:39, gavinp wrote:
> So this is OK because downloads are never range_requested?
> 
> What happens if we get a resource cached sparsely for some use, then do a
> download: will we still tickle bug 22900?