Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 8632022: Add OVERRIDE to chrome/browser/ui/gtk/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, asanka, Erik does not do reviews, yoshiki+watch_chromium.org, Randy Smith (Not in Mondays), dcheng, mihaip+watch_chromium.org, Aaron Boodman, James Su
Visibility:
Public.

Description

Add OVERRIDE to chrome/browser/ui/gtk/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -225 lines) Patch
M chrome/browser/ui/gtk/back_forward_button_gtk.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h View 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_instructions_gtk.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h View 3 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.h View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.h View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/collected_cookies_gtk.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/content_setting_bubble_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/custom_button.h View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/custom_drag.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_shelf_gtk.h View 2 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.h View 2 chunks +22 lines, -20 lines 0 comments Download
M chrome/browser/ui/gtk/first_run_dialog.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/global_menu_bar.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.h View 3 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_tree.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/hover_controller_gtk.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/html_dialog_gtk.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/js_modal_dialog_gtk.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.h View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/overflow_button.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/reload_button_gtk.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/repost_form_warning_gtk.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/select_file_dialog_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/slide_animator_gtk.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/status_bubble_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/status_icons/status_icon_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_view_gtk.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.h View 2 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 2 chunks +36 lines, -31 lines 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.h View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
9 years, 1 month ago (2011-11-22 19:50:36 UTC) #1
Elliot Glaysher
9 years, 1 month ago (2011-11-22 20:34:24 UTC) #2
lgtm stamp

On Tuesday, November 22, 2011,  <avi@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> Add OVERRIDE to chrome/browser/ui/gtk/.
>
> BUG=104314
> TEST=no change
>
>
> Please review this at http://codereview.chromium.org/8632022/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/ui/gtk/back_forward_button_gtk.h
>  M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h
>  M chrome/browser/ui/gtk/bookmarks/bookmark_bar_instructions_gtk.h
>  M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.h
>  M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h
>  M chrome/browser/ui/gtk/browser_titlebar.h
>  M chrome/browser/ui/gtk/browser_toolbar_gtk.h
>  M chrome/browser/ui/gtk/browser_window_gtk.h
>  M chrome/browser/ui/gtk/collected_cookies_gtk.h
>  M chrome/browser/ui/gtk/constrained_window_gtk.h
>  M chrome/browser/ui/gtk/content_setting_bubble_gtk.h
>  M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h
>  M chrome/browser/ui/gtk/custom_button.h
>  M chrome/browser/ui/gtk/custom_drag.h
>  M chrome/browser/ui/gtk/download/download_item_gtk.h
>  M chrome/browser/ui/gtk/download/download_shelf_gtk.h
>  M chrome/browser/ui/gtk/extensions/extension_popup_gtk.h
>  M chrome/browser/ui/gtk/find_bar_gtk.h
>  M chrome/browser/ui/gtk/first_run_dialog.h
>  M chrome/browser/ui/gtk/global_history_menu.h
>  M chrome/browser/ui/gtk/global_menu_bar.h
>  M chrome/browser/ui/gtk/gtk_theme_service.h
>  M chrome/browser/ui/gtk/gtk_tree.h
>  M chrome/browser/ui/gtk/hover_controller_gtk.h
>  M chrome/browser/ui/gtk/html_dialog_gtk.h
>  M chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h
>  M chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.h
>  M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h
>  M chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h
>  M chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.h
>  M chrome/browser/ui/gtk/js_modal_dialog_gtk.h
>  M chrome/browser/ui/gtk/location_bar_view_gtk.h
>  M chrome/browser/ui/gtk/notifications/balloon_view_gtk.h
>  M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h
>  M chrome/browser/ui/gtk/overflow_button.h
>  M chrome/browser/ui/gtk/reload_button_gtk.h
>  M chrome/browser/ui/gtk/repost_form_warning_gtk.h
>  M chrome/browser/ui/gtk/select_file_dialog_impl.h
>  M chrome/browser/ui/gtk/slide_animator_gtk.h
>  M chrome/browser/ui/gtk/status_bubble_gtk.h
>  M chrome/browser/ui/gtk/status_icons/status_icon_gtk.h
>  M chrome/browser/ui/gtk/tab_contents_container_gtk.h
>  M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h
>  M chrome/browser/ui/gtk/tabs/dragged_view_gtk.h
>  M chrome/browser/ui/gtk/tabs/tab_gtk.h
>  M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.h
>  M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h
>  M chrome/browser/ui/gtk/task_manager_gtk.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698