GTK: Port to gdk_x11_window_lookup_for_display

GTK: Port to gdk_x11_window_lookup_for_display

This API replaces gdk_window_lookup and gdk_xid_table_lookup which are
deprecated in 2.24. gdk_x11_window_lookup_for_display was added in 2.24.

As well porting the users to use this new API a compatability version was
added to the ui/base/gtk/gtk_compat.h file.

BUG=79722
TEST=Compiles and ui_unittests run. Chrome also runs.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112258

[Elliot Glaysher, 2011-11-28 18:39:28]

http://codereview.chromium.org/8632021/diff/1/ui/base/gtk/gtk_compat.h
File ui/base/gtk/gtk_compat.h (right):

http://codereview.chromium.org/8632021/diff/1/ui/base/gtk/gtk_compat.h#newcode38
ui/base/gtk/gtk_compat.h:38: inline GdkWindow*
gdk_x11_window_lookup_for_display(GdkDisplay* display, Window window)
linebreak on the comma before Window; we have an 80 char limit. Indent Window to
line up with GdkDisplay, put brace on same line as the closing ')'. In general,
please match the style guide
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml)

[robert.bradford, 2011-11-29 12:04:04]

http://codereview.chromium.org/8632021/diff/1/ui/base/gtk/gtk_compat.h
File ui/base/gtk/gtk_compat.h (right):

http://codereview.chromium.org/8632021/diff/1/ui/base/gtk/gtk_compat.h#newcode38
ui/base/gtk/gtk_compat.h:38: inline GdkWindow*
gdk_x11_window_lookup_for_display(GdkDisplay* display, Window window)
On 2011/11/28 18:39:28, Elliot Glaysher wrote:
> linebreak on the comma before Window; we have an 80 char limit. Indent Window
to
> line up with GdkDisplay, put brace on same line as the closing ')'. In
general,
> please match the style guide
> (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml)

Done. And I also changed from a C style cast.

[Elliot Glaysher, 2011-11-29 21:38:36]

lgtm

[commit-bot: I haz the power, 2011-11-29 21:39:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.bradford@intel.com/8632021/4002

[commit-bot: I haz the power, 2011-11-29 21:39:10]

Can't apply patch for file ui/base/x/active_window_watcher_x.cc.
While running patch -p1 --forward --force;
patching file ui/base/x/active_window_watcher_x.cc
Hunk #1 succeeded at 6 with fuzz 2 (offset 1 line).
Hunk #2 FAILED at 88.
1 out of 2 hunks FAILED -- saving rejects to file
ui/base/x/active_window_watcher_x.cc.rej

[robert.bradford, 2011-11-29 22:05:57]

Here is an updated version that is rebased to deal with changes in r111171

[commit-bot: I haz the power, 2011-11-29 22:08:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.bradford@intel.com/8632021/10001

[commit-bot: I haz the power, 2011-11-29 22:08:47]

Presubmit check for 8632021-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
ui/gfx/gtk_native_view_id_manager.cc,ui/base/x/x11_util.cc,ui/base/x/active_window_watcher_x.cc

Presubmit checks took 1.4s to calculate.

[sky, 2011-11-29 22:10:24]

Rubber stamp LGTM

[commit-bot: I haz the power, 2011-11-29 22:11:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.bradford@intel.com/8632021/10001

[commit-bot: I haz the power, 2011-11-29 22:34:24]

Try job failure for 8632021-10001 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[robert.bradford, 2011-11-29 22:36:00]

On 2011/11/29 22:11:46, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>
https://chromium-status.appspot.com/cq/robert.bradford%40intel.com/8632021/10001

The build fails because gtk has changed what gets included in the single header
between the version the buildbot is using and what I have.

I'm evaluating adding the explicit include of gdk/gdkx.h. I'll update once I've
tested it builds with that.

[robert.bradford, 2011-11-29 22:47:58]

We need to include <gdk/gdkx.h> to get both the X11 symbols and all the gdk_x11_
symbols.

[Elliot Glaysher, 2011-11-29 22:54:15]

http://codereview.chromium.org/8632021/diff/9004/ui/base/gtk/gtk_compat.h
File ui/base/gtk/gtk_compat.h (right):

http://codereview.chromium.org/8632021/diff/9004/ui/base/gtk/gtk_compat.h#new...
ui/base/gtk/gtk_compat.h:10: #include <gdk/gdkx.h>
Please move this and the copmat function to their own header. We've had problems
with xlib's headers polluting the namespace before and we don't want this
commonly included.

[robert.bradford, 2011-11-30 16:38:27]

Elliot, I also copied the blurb from the gtk_compat.h header to gdk_x_compat.h
too.

I was able to test all this against a GTK 2.18.0 build.

http://codereview.chromium.org/8632021/diff/9004/ui/base/gtk/gtk_compat.h
File ui/base/gtk/gtk_compat.h (right):

http://codereview.chromium.org/8632021/diff/9004/ui/base/gtk/gtk_compat.h#new...
ui/base/gtk/gtk_compat.h:10: #include <gdk/gdkx.h>
On 2011/11/29 22:54:15, Elliot Glaysher wrote:
> Please move this and the copmat function to their own header. We've had
problems
> with xlib's headers polluting the namespace before and we don't want this
> commonly included.

Done! Moved that function to a gdk_x_compat.h header and included it in only the
appropriate places.

[Elliot Glaysher, 2011-11-30 17:31:24]

Thank you. LGTM now. Throwing in the commit queue.

[commit-bot: I haz the power, 2011-11-30 17:31:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.bradford@intel.com/8632021/15001

[commit-bot: I haz the power, 2011-11-30 18:49:49]

Change committed as 112258