Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8632016: Redo of Issue 8621006: Remove most obvious TOUCH_UI code. (Closed)

Created:
9 years, 1 month ago by Emmanuel Saint-loubert-Bié
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, kkania, penghuang+watch_chromium.org, dcheng, robertshield, Paweł Hajdan Jr., James Su, dhollowa
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Redo of Issue http://codereview.chromium.org/8621006/ Removed most obvious TOUCH_UI tests. Either obvious because we have USE_AURA | TOUCH_UI or because it is in a GTK module. This CL focuses mainly on Views cleanup. BUG=105046 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111204

Patch Set 1 #

Patch Set 2 : Merged (again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -279 lines) Patch
M chrome/browser/automation/ui_controls_gtk.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/notifications/balloon_collection_gtk.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/dialog_stubs_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host_gtk.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M ui/ui.gyp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M views/controls/menu/menu_config_aura.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M views/controls/menu/menu_config_linux.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M views/controls/menu/menu_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_host.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M views/controls/menu/menu_item_view.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M views/controls/menu/nested_dispatcher_gtk.h View 2 chunks +0 lines, -8 lines 0 comments Download
M views/controls/menu/nested_dispatcher_gtk.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M views/controls/native_control_gtk.h View 1 chunk +0 lines, -10 lines 0 comments Download
M views/controls/native_control_gtk.cc View 2 chunks +0 lines, -150 lines 0 comments Download
M views/controls/textfield/native_textfield_views_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M views/mouse_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/views.gyp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emmanuel Saint-loubert-Bié
Hi Scott, Sorry for the spam the CQ is not cooperating. Gan you please give ...
9 years, 1 month ago (2011-11-22 17:38:26 UTC) #1
sky
Feel free to TBR these LGTM
9 years, 1 month ago (2011-11-22 17:46:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8632016/4001
9 years, 1 month ago (2011-11-22 19:03:44 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 20:30:15 UTC) #4 
Change committed as 111204

Powered by Google App Engine
This is Rietveld 408576698