Issue 8632014: Enable protector by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8632014: Enable protector by default (Closed)

Created:
9 years, 1 month ago by whywhat

Modified:
9 years, 1 month ago

Reviewers:
Ivan Korotkov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable protector by default R=ivankr@chromium.org BUG=102765 TEST=Check that Protector is enabled by default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111227

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed spaces #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	chrome/browser/search_engines/template_url_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Korotkov

9 years, 1 month ago (2011-11-22 18:14:12 UTC) #2

LGTM with:

http://codereview.chromium.org/8632014/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/8632014/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:704: const char kIncognito[]                  
= "incognito";
Return these spaces back please :)

Expand Messages | Collapse Messages