Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/tcmalloc/chromium/src/malloc_hook.cc

Issue 8632007: A deeper heap profile dumper in third_party/tcmalloc/chromium. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Refactored. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/tcmalloc/chromium/src/malloc_hook.cc
diff --git a/third_party/tcmalloc/chromium/src/malloc_hook.cc b/third_party/tcmalloc/chromium/src/malloc_hook.cc
index f6af7d816179e91afabcc6838ad5fbb99ec1791e..d7afee38a7f0b34d10054331f34dd91c502df143 100644
--- a/third_party/tcmalloc/chromium/src/malloc_hook.cc
+++ b/third_party/tcmalloc/chromium/src/malloc_hook.cc
@@ -677,7 +677,9 @@ extern "C" int MallocHook_GetCallerStackTrace(void** result, int max_depth,
if (InHookCaller(stack[i])) {
RAW_VLOG(10, "Found hooked allocator at %d: %p <- %p",
i, stack[i], stack[i+1]);
- i += 1; // skip hook caller frame
+ // i += 1; // skip hook caller frame
Alexander Potapenko 2011/12/20 13:57:23 Please add an "if FLAG_deep_profile..." here inste
Dai Mikurube (NOT FULLTIME) 2011/12/21 09:13:49 Done.
+ // In deep profiler, we want to know the caller frame to
+ // distinguish mmap from tcmalloc
depth -= i; // correct depth
if (depth > max_depth) depth = max_depth;
copy(stack + i, stack + i + depth, result);

Powered by Google App Engine
This is Rietveld 408576698