Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 8632006: Allow POST method when converting file protocol to http protocol for layout tests. (Closed)

Created:
9 years, 1 month ago by Jing Zhao
Modified:
9 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Allow POST method when converting file protocol to http protocol for layout tests. When running layout tests on Android, we host test files on a Linux/Mac machine, convert file requests to http requests, and forward http requests from Android to the same port on the host machine. The following tests use POST method and failed at DCHECK(params->method == "GET" || params->method.empty()): fast/events/popup-allowed-from-gesture-initiated-form-submit.html fast/forms/document-write.html fast/forms/form-and-frame-interaction-retains-values.html fast/forms/form-data-encoding-normalization-overrun.html fast/forms/form-post-urlencoded.html fast/forms/formmethod-attribute-button-html.html fast/forms/formmethod-attribute-input-html.html fast/forms/submit-to-url-fragment.html fast/forms/xss-auditor-doesnt-crash-on-post-submit.html fast/history/form-submit-in-frame-via-onclick.html fast/history/form-submit-in-frame.html fast/loader/form-submission-after-beforeunload-cancel.html fast/loader/form-submit-aborts-parsing.html fast/loader/submit-form-while-parsing-1.xhtml The following test loads an image referred by the test page, and failed at DCHECK(params->referrer.is_empty()): http/tests/security/local-image-from-remote-whitelisted.html BUG=http://b/5655809 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jing Zhao
Hi Tony, Could you help to review this change? Thanks, Jing
9 years, 1 month ago (2011-11-22 08:04:10 UTC) #1
tony
The change seems OK, but can you update the change description to explain why you ...
9 years, 1 month ago (2011-11-22 17:24:32 UTC) #2
tony
LGTM. I would add BUG=http://b/5655809 to the change description. It's not a secret that there's ...
9 years, 1 month ago (2011-11-23 07:55:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jingzhao@chromium.org/8632006/1
9 years, 1 month ago (2011-11-23 09:10:14 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 10:12:04 UTC) #5
Change committed as 111342

Powered by Google App Engine
This is Rietveld 408576698