Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8632001: Removed TOUCH_UI (mostly constants) from chrome/browser/ui/views. (Closed)

Created:
9 years, 1 month ago by Emmanuel Saint-loubert-Bié
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, msw+watch_chromium.org, yusukes+watch_chromium.org, tfarina, James Su, kkania, penghuang+watch_chromium.org, dcheng, robertshield, Paweł Hajdan Jr., alicet1, dhollowa
Visibility:
Public.

Description

Removed TOUCH_UI (mostly constants) from chrome/browser/ui/views. BUG=105046 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111184

Patch Set 1 #

Patch Set 2 : Merge. #

Patch Set 3 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -132 lines) Patch
M chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/bubble/bubble.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_host.cc View 1 2 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 4 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_container_native.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_container_native.cc View 2 chunks +0 lines, -46 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 2 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emmanuel Saint-loubert-Bié
Hi Scott, More cleanup. Mostly of constants that were added through lengthy experimentation :-) -- ...
9 years, 1 month ago (2011-11-22 02:19:17 UTC) #1
Emmanuel Saint-loubert-Bié
Not sure why, but this CL for closed. PTAL. Thanks, -- Emmanuel
9 years, 1 month ago (2011-11-22 06:12:26 UTC) #2
sky
LGTM
9 years, 1 month ago (2011-11-22 15:56:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8632001/5001
9 years, 1 month ago (2011-11-22 17:09:00 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 18:45:17 UTC) #5 
Change committed as 111184

Powered by Google App Engine
This is Rietveld 408576698