chrome/common/extensions/api/extension_api.json - Issue 8631017: Change the first parameter of savePage.saveAsMHTML to be a dictionary. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(6573)

My Issues | Starred Open | Closed | All

Unified Diff: chrome/common/extensions/api/extension_api.json

Issue 8631017: Change the first parameter of savePage.saveAsMHTML to be a dictionary. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reverted test change. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/extensions/extension_save_page_api.cc ('k') | chrome/common/extensions/docs/experimental.savePage.html » ('j') | chrome/common/extensions/docs/experimental.savePage.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_api.json

diff --git a/chrome/common/extensions/api/extension_api.json b/chrome/common/extensions/api/extension_api.json

index 1fb9a7d955f1e5f003e803e817b6eba1ed0a5068..5527138577fc039140b5e9b34485ac64e5e06469 100644

--- a/chrome/common/extensions/api/extension_api.json

+++ b/chrome/common/extensions/api/extension_api.json

@@ -9065,10 +9065,15 @@

"description": "Saves the content of the tab with given id to MHTML.",

"parameters": [

{

- "name": "tabId",

- "type": "integer",

- "minimum": 0,

- "description": "The id of the tab to save."

+ "name": "details",

+ "type": "object",

+ "properties": {

+ "tabId": {

+ "type": "integer",

+ "minimum": 0,

+ "description": "The id of the tab to save to MHTML."

asargent_no_longer_on_chrome 2011/11/22 18:43:41 would this read better if you had "as MHTML" inste

+ }

+ }

},

{

"name": "callback",

« no previous file with comments | « chrome/browser/extensions/extension_save_page_api.cc ('k') | chrome/common/extensions/docs/experimental.savePage.html » ('j') | chrome/common/extensions/docs/experimental.savePage.html » ('J')

Powered by Google App Engine

This is Rietveld 408576698