Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 8631017: Change the first parameter of savePage.saveAsMHTML to be a dictionary. (Closed)

Created:
9 years, 1 month ago by Jay Civelli
Modified:
4 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Change the first parameter of savePage.saveAsMHTML to be a dictionary. This CL makes the first parameter of the experimental savePage.saveAsMHTML API a dictionary, so the API can easily be extended in the future. BUG=None TEST=browser_tests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111249

Patch Set 1 #

Patch Set 2 : Reverted test change. #

Total comments: 2

Patch Set 3 : Applied Antony's suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -12 lines) Patch
M chrome/browser/extensions/extension_save_page_api.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 2 1 chunk +10 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.savePage.html View 5 chunks +71 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/static/experimental.savePage.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/save_page/test.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jay Civelli
9 years, 1 month ago (2011-11-22 18:38:26 UTC) #1
asargent_no_longer_on_chrome
LGTM http://codereview.chromium.org/8631017/diff/2001/chrome/common/extensions/api/extension_api.json File chrome/common/extensions/api/extension_api.json (right): http://codereview.chromium.org/8631017/diff/2001/chrome/common/extensions/api/extension_api.json#newcode9074 chrome/common/extensions/api/extension_api.json:9074: "description": "The id of the tab to save ...
9 years, 1 month ago (2011-11-22 18:43:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/8631017/3006
9 years, 1 month ago (2011-11-22 21:16:52 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 23:27:17 UTC) #4
Change committed as 111249

Powered by Google App Engine
This is Rietveld 408576698