Issue 8631012: Upstream Android V8 change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8631012: Upstream Android V8 change. (Closed)

Created:
9 years, 1 month ago by Jing Zhao

Modified:
9 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, michaelbai, John Grabowski, Peter Beverloo

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Upstream Android V8 change. Fix the Mac build. "_toolset" needs to be tested inside target_conditions now. And there is no need to have -llog any more. Committed: http://code.google.com/p/v8/source/detail?r=10057

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	tools/gyp/v8.gyp	View		2 chunks	+12 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jing Zhao

Hi Jakob, Could you help to review this change? Thanks, Jing

9 years, 1 month ago (2011-11-22 15:17:13 UTC) #1

Jakob Kummerow

9 years, 1 month ago (2011-11-23 09:46:16 UTC) #2

LGTM, I'll land.

http://codereview.chromium.org/8631012/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8631012/diff/1/build/common.gypi#newcode144
build/common.gypi:144: ['host_arch=="x64" or OS=="android"', {
This is a little hacky, but it's OK for now. Medium-term, I think I'd like to
bundle all Android-specific settings in one section (or even .gypi file).

Expand Messages | Collapse Messages