Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 8631004: Use the same factor to decide if popup should tab as on non aura chromeos (Closed)

Created:
9 years, 1 month ago by oshima
Modified:
9 years, 1 month ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, penghuang+watch_chromium.org, yusukes+watch_chromium.org, Erik does not do reviews, jam, mihaip+watch_chromium.org, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., James Su
Visibility:
Public.

Description

Use the same factor as on non aura chromeos to decide if popup should be opened as tab. This fixes ExtensionApiTest.WindowOpenPopupLarge on aura/chromeos I simply copied factor from chromeos frame as this value will have to be adjusted for new desktop and chromeos frame code will go away. BUG=103490 TEST=ExtensionApiTest.WindowOpenPopupLarge passes on aura/chromeos Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111285

Patch Set 1 : " #

Patch Set 2 : " #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M chrome/browser/extensions/window_open_apitest.cc View 1 4 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 chunks +21 lines, -9 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
oshima
9 years, 1 month ago (2011-11-22 04:37:55 UTC) #1
sadrul
LGTM http://codereview.chromium.org/8631004/diff/4002/chrome/browser/ui/views/frame/browser_view.cc File chrome/browser/ui/views/frame/browser_view.cc (right): http://codereview.chromium.org/8631004/diff/4002/chrome/browser/ui/views/frame/browser_view.cc#newcode1326 chrome/browser/ui/views/frame/browser_view.cc:1326: int max_height = size.height() * kPopupMaxHeightFactor; Ah, my ...
9 years, 1 month ago (2011-11-22 21:40:24 UTC) #2
oshima
+sky for OWNERS approval
9 years, 1 month ago (2011-11-22 21:53:34 UTC) #3
sky
LGTM
9 years, 1 month ago (2011-11-22 22:35:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8631004/4002
9 years, 1 month ago (2011-11-22 22:51:02 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 02:07:16 UTC) #6
Change committed as 111285

Powered by Google App Engine
This is Rietveld 408576698