[ntp4] Use highest quality jpeg compression for thumbnail images.

[ntp4] Use highest quality jpeg compression for thumbnail images.

BUG=94640
TEST=Verify thumbnails are still added to NTP page.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111720

[csilv, 2011-11-22 02:47:29]

+estade for review

This is the "easy" solution for removing compression artifacts.  The alternative
would be to migrate to PNGEncodedDataFromImage, but that would require changing
the db since we don't store any indication of what format the data is in.

As expected, images are larger... but since we only stroe a limited number of
thumbnails (and the thumbnails are so small), the size different is not
significant.  Examples:

  twitter.com: 4609 -> 14375
  firefox.com: 6213 -> 17349

[csilv, 2011-11-22 03:02:37]

Couple additional notes:

1. I felt it was odd that the compression level was hard coded into
image_util.cc, so I made that a parameter instead.
2. The usage in thumbnail_database.cc is obsolete... but I needed to put
something there to compile.  I decided to use the old value of 90 for that use.

[Evan Stade, 2011-11-23 22:06:13]

lgtm

I wonder how long we need to keep migration code around, especially code like
this; it's not a big deal to toss out thumbnails and start over, and the number
of users hitting this migration path must be vanishingly small by now.

[csilv, 2011-11-23 22:31:38]

+sky for owners approval

[csilv, 2011-11-23 22:32:14]

On 2011/11/23 22:31:38, csilv wrote:
> +sky for owners approval

(sky for u/gfx/image/image_util.cc, .h)

[sky, 2011-11-28 15:44:37]

LGTM

http://codereview.chromium.org/8631002/diff/2001/ui/gfx/image/image_util.h
File ui/gfx/image/image_util.h (right):

http://codereview.chromium.org/8631002/diff/2001/ui/gfx/image/image_util.h#ne...
ui/gfx/image/image_util.h:33: UI_EXPORT bool JPEGEncodedDataFromImage(const
Image& image, int quality,
nit: each param on its own line.

[csilv, 2011-11-28 18:04:40]

http://codereview.chromium.org/8631002/diff/2001/ui/gfx/image/image_util.h
File ui/gfx/image/image_util.h (right):

http://codereview.chromium.org/8631002/diff/2001/ui/gfx/image/image_util.h#ne...
ui/gfx/image/image_util.h:33: UI_EXPORT bool JPEGEncodedDataFromImage(const
Image& image, int quality,
On 2011/11/28 15:44:37, sky wrote:
> nit: each param on its own line.

Done.