Issue 8626001: Use a real .jar for dangerous downloads tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8626001: Use a real .jar for dangerous downloads tests (Closed)

Created:
9 years, 1 month ago by Nirnimesh

Modified:
9 years, 1 month ago

Reviewers:
Randy Smith (Not in Mondays)

CC:
chromium-reviews, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Use a real .jar for dangerous downloads tests Use a real .jar because chrome ends up displaying a plain/text .jar file as text. BUG=104886 TEST=pyauto test: testDeclineDangerousDownload Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111038

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, -0 lines)			Patch
	M	chrome/test/data/downloads/dangerous/dangerous.jar	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
	M	chrome/test/functional/PYAUTO_TESTS	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Nirnimesh

I'm still working on downloads.DownloadsTest.testSaveDangerousFile -- for some reason a dangerous download triggered through automation ...

9 years, 1 month ago (2011-11-21 22:18:20 UTC) #2

LGTM.