Issue 8625005: [Sync] Make ModelSafeWorker a true interface

Issue 8625005: [Sync] Make ModelSafeWorker a true interface (Closed)

Created:
9 years, 1 month ago by akalin

Modified:
9 years, 1 month ago

Reviewers:
Nicolas Zea, tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Make ModelSafeWorker a true interface Make PassiveModelWorker class. Make FakeModelWorker class and make tests use it. Also make some tests use realistic groups instead of shunting everything to GROUP_PASSIVE. Rename MockModelSafeWorkerRegistrar to FakeModelSafeWorkerRegistrar. This will make it easier to test an upcoming change that makes ModelChangingSyncerCommand post on only the threads it needs to. BUG=97832 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111131

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+307 lines, -198 lines)			Patch
M	chrome/browser/sync/engine/apply_updates_command_unittest.cc	View		9 chunks	+31 lines, -13 lines	0 comments	Download
M	chrome/browser/sync/engine/download_updates_command_unittest.cc	View		3 chunks	+13 lines, -23 lines	0 comments	Download
D	chrome/browser/sync/engine/mock_model_safe_workers.h	View		1 chunk	+0 lines, -52 lines	0 comments	Download
D	chrome/browser/sync/engine/mock_model_safe_workers.cc	View		1 chunk	+0 lines, -58 lines	0 comments	Download
M	chrome/browser/sync/engine/model_safe_worker.h	View		1 chunk	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/engine/model_safe_worker.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
A	chrome/browser/sync/engine/passive_model_worker.h	View	1 2	1 chunk	+39 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/engine/passive_model_worker.cc	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/process_commit_response_command_unittest.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/engine/sync_scheduler_unittest.cc	View		3 chunks	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/sync/engine/sync_scheduler_whitebox_unittest.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/engine/verify_updates_command_unittest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/glue/DEPS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/browser_thread_model_worker.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_registrar.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sessions/sync_session_unittest.cc	View		4 chunks	+7 lines, -7 lines	0 comments	Download
A	chrome/browser/sync/test/engine/fake_model_safe_worker_registrar.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/test/engine/fake_model_safe_worker_registrar.cc	View		1 chunk	+40 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/test/engine/fake_model_worker.h	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/test/engine/fake_model_worker.cc	View	1 2	1 chunk	+31 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download