Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 8625004: aura: Fix input method and a11y status area browser tests. (Closed)

Created:
9 years, 1 month ago by Daniel Erat
Modified:
9 years, 1 month ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org, Yusuke Sato
Visibility:
Public.

Description

aura: Fix input method and a11y status area browser tests. This fixes InputMethodMenuButtonTest and AccessibilityMenuButtonTest, which were failing due to the same NULL-status-area problem as the tests fixed by r110851 and r111006. BUG=103482, 103492 TEST=ran them for both aura and non-aura chrome os Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M chrome/browser/chromeos/status/accessibility_menu_button_browsertest.cc View 2 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button_browsertest.cc View 2 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Daniel Erat
9 years, 1 month ago (2011-11-22 00:03:41 UTC) #1
Emmanuel Saint-loubert-Bié
lgtm
9 years, 1 month ago (2011-11-22 00:33:04 UTC) #2
DaveMoore
9 years, 1 month ago (2011-11-22 00:51:00 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698