Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 8625001: GTK: Part 1 of removing GtkWidget->window to close up GSEALs. (Closed)

Created:
9 years, 1 month ago by Elliot Glaysher
Modified:
9 years, 1 month ago
Reviewers:
Lei Zhang, Evan Stade
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, nkostylev+watch_chromium.org, brettw-cc_chromium.org, kkania, robertshield, Paweł Hajdan Jr., ajwong+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Part 1 of removing GtkWidget->window to close up GSEALs. (The accessor gtk_widget_get_window was added in 2.14, so it was never used in initial linux port development.) BUG=79722 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111091

Patch Set 1 #

Patch Set 2 : Ignore chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -35 lines) Patch
M chrome/browser/automation/automation_provider_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/ui_controls_gtk.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 15 chunks +24 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
Whichever one of you get to it first.
9 years, 1 month ago (2011-11-22 01:15:18 UTC) #1
Evan Stade
lgtm
9 years, 1 month ago (2011-11-22 02:10:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8625001/2001
9 years, 1 month ago (2011-11-22 02:17:06 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 03:34:53 UTC) #4
Change committed as 111091

Powered by Google App Engine
This is Rietveld 408576698