Issue 8624004: Chromeos: Only set email text if there is a logged in user

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8624004: Chromeos: Only set email text if there is a logged in user (Closed)

Created:
9 years, 1 month ago by DaveMoore

Modified:
9 years, 1 month ago

Reviewers:
zel, Ivan Korotkov

CC:
chromium-reviews, Emmanuel Saint-loubert-Bié

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Chromeos: Only set email text if there is a logged in user 35 tests fail because we are setting the localized text for the string userEmail to the logged in email for a user, but in the test environment there is no logged in user. BUG=105049 TEST=Various browser tests, including DownloadTest.ChromeURLAfterDownload Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111026

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/ui/webui/options/personal_options_handler.cc	View		1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zel

9 years, 1 month ago (2011-11-21 23:04:18 UTC) #2

LGTM with a nit:

http://codereview.chromium.org/8624004/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/personal_options_handler.cc (right):

http://codereview.chromium.org/8624004/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/personal_options_handler.cc:205: if
(chromeos::UserManager::Get()->user_is_logged_in())
{} missing

Expand Messages | Collapse Messages