Register Browser for extension events from the original profile.

Register Browser for extension events from the original profile.

This fixes incognito windows that weren't properly updating when extensions were loaded or unloaded.

BUG=103419, 104525
TEST=See reproduction steps in 103419, comment 2. When an incognito window is open and an extension with page action is enabled or disabled, the action should appear or disappear in the incognito location bar accordingly.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111205

[Yoyo Zhou, 2011-11-22 01:01:19]

finnur: Unless you were also seeing issues with page actions not updating in a
non-incognito window, this ought to be the root cause; so I don't know how much
of r109011 would be subsumed by this.

[Finnur, 2011-11-22 10:49:45]

This makes sense, so LGTM. However, I think we have (had) two problems, one is
this issue and another is the PageActionView potentially not updating in all
cases. The fix for 99736 addresses the update problem to some degree at least,
so this is not the fix for that (I would think) and unclear whether this is the
fix for 104525 (Mac crash). I would update both bugs to mention this fix,
though, but at least take out 99736 from the BUG= list. If you think this is
also the fix for the Mac crash then I'd like to know about it (and Scott Hess
too, probably).

[Yoyo Zhou, 2011-11-22 19:06:48]

On 2011/11/22 10:49:45, Finnur wrote:
> This makes sense, so LGTM. However, I think we have (had) two problems, one is
> this issue and another is the PageActionView potentially not updating in all
> cases. The fix for 99736 addresses the update problem to some degree at least,
> so this is not the fix for that (I would think) and unclear whether this is
the
> fix for 104525 (Mac crash). I would update both bugs to mention this fix,
> though, but at least take out 99736 from the BUG= list. If you think this is
> also the fix for the Mac crash then I'd like to know about it (and Scott Hess
> too, probably).

Ok, I'll take 99736 off the bug list. I haven't looked at the page action UI in
as much depth as I have the browser action UI (which seems to be more of a
direct port from platform to platform).

I'll test this on Mac today also.

[commit-bot: I haz the power, 2011-11-22 19:10:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/8623008/1

[Yoyo Zhou, 2011-11-22 20:47:00]

On 2011/11/22 19:06:48, Yoyo Zhou wrote:
> I'll test this on Mac today also.

Yes, this seems to fix the crashing issues with Mac that I could trigger.

After this lands I'll look for crash reports from dev/canary to see if it's
still showing up.

[commit-bot: I haz the power, 2011-11-22 20:47:39]

Change committed as 111205