Issue 8623007: Restore call to instantiate NotificationUIManager to fix perf timers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8623007: Restore call to instantiate NotificationUIManager to fix perf timers. (Closed)

Created:
9 years, 1 month ago by stevenjb

Modified:
9 years, 1 month ago

Reviewers:
Nicolas Sylvain, jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Restore call to instantiate NotificationUIManager to fix perf timers. BUG=105056 TEST=Check perf timers, should be back to pre-110853 values. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111055

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add issue to comment #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/chrome_browser_main.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

The purpose of this CL: http://codereview.chromium.org/8550003 was to set the ui_manager for all notification services ...

9 years, 1 month ago (2011-11-21 23:48:42 UTC) #1

jam

lgtm how sad! http://codereview.chromium.org/8623007/diff/1/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): http://codereview.chromium.org/8623007/diff/1/chrome/browser/chrome_browser_main.cc#newcode1864 chrome/browser/chrome_browser_main.cc:1864: // used to measure startup time. ...

9 years, 1 month ago (2011-11-22 00:30:57 UTC) #2

commit-bot: I haz the power

9 years, 1 month ago (2011-11-22 00:40:18 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/8623007/1

Expand Messages | Collapse Messages