Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8623005: aura: Add back XInputHierarchyChangedEventListener for aura and remove stubs. (Closed)

Created:
9 years, 1 month ago by sadrul
Modified:
9 years, 1 month ago
Reviewers:
DaveMoore
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

aura: Add back XInputHierarchyChangedEventListener for aura and remove stubs. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111099

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -97 lines) Patch
M chrome/browser/chromeos/cros_stubs_aura.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.h View 1 2 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc View 1 3 chunks +2 lines, -47 lines 0 comments Download
A chrome/browser/chromeos/xinput_hierarchy_changed_event_listener_aura.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/xinput_hierarchy_changed_event_listener_gtk.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
9 years, 1 month ago (2011-11-21 23:42:25 UTC) #1
DaveMoore
http://codereview.chromium.org/8623005/diff/1/chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc File chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc (right): http://codereview.chromium.org/8623005/diff/1/chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc#newcode83 chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc:83: #if !defined(TOOLKIT_USES_GTK) From this point on there's not much ...
9 years, 1 month ago (2011-11-22 00:04:47 UTC) #2
sadrul
http://codereview.chromium.org/8623005/diff/1/chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc File chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc (right): http://codereview.chromium.org/8623005/diff/1/chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc#newcode83 chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc:83: #if !defined(TOOLKIT_USES_GTK) On 2011/11/22 00:04:47, DaveMoore wrote: > From ...
9 years, 1 month ago (2011-11-22 02:27:43 UTC) #3
DaveMoore
9 years, 1 month ago (2011-11-22 03:34:47 UTC) #4 
lgtm. Thanks for cleaning this all up.

Powered by Google App Engine
This is Rietveld 408576698