Issue 8623004: Remove the test for mime-type text/plain as this seems to be based on suffix only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8623004: Remove the test for mime-type text/plain as this seems to be based on suffix only. (Closed)

Created:
9 years, 1 month ago by achuithb

Modified:
9 years, 1 month ago

Reviewers:
kmixter1, Charlie Lee

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove the test for mime-type text/plain as this seems to be based on suffix only. Files with .onc extension are not recognized as text/plain files. ONCNetworkParser should fail on non-text files, so this test is not necessary. BUG=chromium-os:23248 TEST=Importing an onc file with .onc suffix should work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111084

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	chrome/browser/resources/options/chromeos/internet_options.js	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/8623004/1

9 years, 1 month ago (2011-11-22 00:17:57 UTC) #3

Change committed as 111084

Expand Messages | Collapse Messages