Issue 8622007: Fix testSaveDangerousFile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8622007: Fix testSaveDangerousFile (Closed)

Created:
9 years, 1 month ago by Nirnimesh

Modified:
9 years, 1 month ago

Reviewers:
Randy Smith (Not in Mondays)

CC:
chromium-reviews, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix testSaveDangerousFile Use dangerous.com on windows. BUG=104886 TEST=pyauto test testSaveDangerousFile R=rdsmith@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111201

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, --1 lines)			Patch
	A	chrome/test/data/downloads/dangerous/dangerous.com	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
	M	chrome/test/functional/downloads.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randy Smith (Not in Mondays)

I'd love to understand why .jar isn't working on Windows. I'm a big believer in ...

9 years, 1 month ago (2011-11-22 02:12:08 UTC) #2

Nirnimesh

9 years, 1 month ago (2011-11-22 08:29:01 UTC) #3

On 2011/11/22 02:12:08, rdsmith wrote:
> I'd love to understand why .jar isn't working on Windows.  I'm a big believer
in
> "if you don't understand it, it's dangerous".  Having said that, LGTM.

That was puzzling to me too and I could not repro it manually; but through
automation I'd get 0bytes reliably. :(

Expand Messages | Collapse Messages