Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4043)

Unified Diff: chrome/browser/ui/browser.cc

Issue 8622006: Don't show first run bubble for non-tabbed windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: a Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 49d66f9b63b79933dd8ffa200f17624c557776cf..301bd8fa6c2767d908a75f8752f203a38e20a727 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -5467,6 +5467,10 @@ void Browser::OnWindowDidShow() {
return;
window_has_shown_ = true;
+ // Nothing to do for non-tabbed windows.
+ if (!is_type_tabbed())
+ return;
+
// Suppress the first run bubble if we're showing the sync promo.
TabContents* contents = GetSelectedTabContents();
bool is_showing_promo = contents &&
@@ -5491,7 +5495,7 @@ void Browser::OnWindowDidShow() {
// windows.
local_state->SetBoolean(prefs::kShouldShowFirstRunBubble, false);
window_->GetLocationBar()->ShowFirstRunBubble(bubble_type);
- } else if (is_type_tabbed()) {
+ } else {
GlobalErrorService* service =
GlobalErrorServiceFactory::GetForProfile(profile());
GlobalError* error = service->GetFirstGlobalErrorWithBubbleView();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698