Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8622005: Get rid of view_messages.h include from chrome since TabContentsDelegate used a struct from it (V... (Closed)

Created:
9 years, 1 month ago by jam
Modified:
9 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Erik does not do reviews, ajwong+watch_chromium.org, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Get rid of view_messages.h include from chrome since TabContentsDelegate used a struct from it (ViewHostMsg_RunFileChooser_Params). Moved that to a struct in content/public/common. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111086

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -78 lines) Patch
M chrome/browser/extensions/extension_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/file_select_helper.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/file_select_helper.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser.h View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_delegate.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_message_enums.h View 1 chunk +0 lines, -18 lines 0 comments Download
M content/common/view_messages.h View 6 chunks +12 lines, -19 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A content/public/common/file_chooser_params.h View 1 chunk +53 lines, -0 lines 0 comments Download
A content/public/common/file_chooser_params.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
9 years, 1 month ago (2011-11-22 01:07:55 UTC) #1
Elliot Glaysher
lgtm
9 years, 1 month ago (2011-11-22 01:13:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/8622005/6003
9 years, 1 month ago (2011-11-22 01:19:09 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 02:45:30 UTC) #4 
Change committed as 111086

Powered by Google App Engine
This is Rietveld 408576698