Issue 8622002: Jack up timeouts for buildbots running android tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8622002: Jack up timeouts for buildbots running android tests. (Closed)

Created:
9 years, 1 month ago by John Grabowski

Modified:
9 years, 1 month ago

Reviewers:
michaelbai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Jack up timeouts for buildbots running android tests. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111025

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	build/android/test_package.py	View		1 chunk	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

michaelbai

lgtm http://codereview.chromium.org/8622002/diff/1/build/android/test_package.py File build/android/test_package.py (right): http://codereview.chromium.org/8622002/diff/1/build/android/test_package.py#newcode52 build/android/test_package.py:52: if os.environ.get('BUILDBOT_SLAVENAME'): What's if the environment was not ...

9 years, 1 month ago (2011-11-21 23:05:53 UTC) #2

John Grabowski

9 years, 1 month ago (2011-11-21 23:07:13 UTC) #3

http://codereview.chromium.org/8622002/diff/1/build/android/test_package.py
File build/android/test_package.py (right):

http://codereview.chromium.org/8622002/diff/1/build/android/test_package.py#n...
build/android/test_package.py:52: if os.environ.get('BUILDBOT_SLAVENAME'):
On 2011/11/21 23:05:53, michaelbai wrote:
> What's if the environment was not set in dev machine? Is there exception
thrown?

No; it returns None.  That's why I'm using get() instead of os.environ['FOO']

Expand Messages | Collapse Messages