Issue 8621003: aura: Rename OnPropertyChanged to OnWindowPropertyChanged.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8621003: aura: Rename OnPropertyChanged to OnWindowPropertyChanged. (Closed)

Created:
9 years, 1 month ago by Daniel Erat

Modified:
9 years, 1 month ago

Reviewers:
oshima, sky

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Rename OnPropertyChanged to OnWindowPropertyChanged. This renames aura::WindowObserver's OnPropertyChanged() method to have the word "window" in its name, as all of the class's other methods do. BUG=none TEST=built it Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111066

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -35 lines)			Patch
M	ui/aura/window.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/aura/window_observer.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/aura/window_unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/aura_shell/always_on_top_controller.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura_shell/always_on_top_controller.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura_shell/modal_container_layout_manager.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura_shell/modal_container_layout_manager.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura_shell/shadow_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/shadow_controller.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura_shell/show_state_controller.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura_shell/show_state_controller.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura_shell/toplevel_layout_manager.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura_shell/toplevel_layout_manager.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

OWNERS strikes again. Scott, mind taking a look for aura/ and aura_shell/?

9 years, 1 month ago (2011-11-22 01:11:19 UTC) #3

LGTM

Expand Messages | Collapse Messages