Reduce minimum size of Panels to allow 1-text-line tight autosize.

chrome/browser/ui/panels/panel_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
@@ skipping 1487 matching lines @@
       content::Source<Browser>(panel_browser));
   panel_browser->ConvertPopupToTabbedBrowser();
   signal.Wait();
   EXPECT_EQ(0, PanelManager::GetInstance()->num_panels());
 
   Browser* tabbed_browser = BrowserList::FindTabbedBrowser(profile, false);
   EXPECT_EQ(contents, tabbed_browser->GetSelectedTabContentsWrapper());
   tabbed_browser->window()->Close();
 }
 
+IN_PROC_BROWSER_TEST_F(PanelBrowserTest, SizeClamping) {
+  // Using small sizes avoids default size to be assigned. In this case
+  // minimum sizes should take effect.
+  CreatePanelParams params("Panel", gfx::Rect(0, 0, 1, 1), SHOW_AS_ACTIVE);
+  Panel* panel = CreatePanelWithParams(params);
+  // These should be in sync with kPanelMinWidth/Height in panel_manager.cc
+  EXPECT_EQ(100, panel->GetBounds().width());

[jennb, 2011/11/22 00:25:26]

Should fetched these numbers from panel_manager. That way the test will continue
to pass even if you decide to change to, say, 101x21.

+  EXPECT_EQ(20, panel->GetBounds().height());
+  panel->Close();
+
+  // Using '0' sizes is equivalent of not providing sizes in API and causes
+  // default sizes to be applied.
+  CreatePanelParams params1("Panel1", gfx::Rect(0, 0, 0, 0), SHOW_AS_ACTIVE);
+  panel = CreatePanelWithParams(params1);
+  // These should be in sync with kPanelDefaultWidth/Height in panel_manager.cc
+  EXPECT_EQ(240, panel->GetBounds().width());

[jennb, 2011/11/22 00:25:26]

Ditto.

+  EXPECT_EQ(290, panel->GetBounds().height());
+  panel->Close();
+}
+
 class PanelDownloadTest : public PanelBrowserTest {
  public:
   PanelDownloadTest() : PanelBrowserTest() { }
 
   // Creates a temporary directory for downloads that is auto-deleted
   // on destruction.
   bool CreateDownloadDirectory(Profile* profile) {
     bool created = downloads_directory_.CreateUniqueTempDir();
     if (!created)
       return false;
@@ skipping 314 matching lines @@
   // position when tall panel brings up its titlebar.
   CloseWindowAndWait(panel1->browser());
   EXPECT_EQ(balloon_bottom_after_tall_panel_titlebar_up,
             GetBalloonBottomPosition(balloon));
 
   // Closing the remaining tall panel should move the notification balloon back
   // to its original position.
   CloseWindowAndWait(panel2->browser());
   EXPECT_EQ(original_balloon_bottom, GetBalloonBottomPosition(balloon));
 }