Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 8621001: Fix pread64, pwrite64, readahead for ARM. (Closed)

Created:
9 years, 1 month ago by Roland McGrath
Modified:
9 years, 1 month ago
Reviewers:
Markus (顧孟勤)
CC:
chromium-reviews, Markus (顧孟勤), Mark Seaborn
Base URL:
http://git.chromium.org/external/linux-syscall-support/lss.git@master
Visibility:
Public.

Description

Fix pread64, pwrite64, readahead for ARM. The system calls taking a 64-bit argument have a special quirk on ARM. The 64-bit argument is passed in a pair of two registers that must be an even/odd pair. If it's an odd-numbered argument, then there is a dummy argument first that is ignored to consume the odd-numbered argument register before the even/odd pair. BUG= none TEST= sys_pread64 now works correctly on ARM R=markus@chromium.org Committed: http://code.google.com/p/linux-syscall-support/source/detail?r=9

Patch Set 1 #

Patch Set 2 : Fix pread64, pwrite64, readahead for ARM. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M lss/linux_syscall_support.h View 1 4 chunks +33 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Roland McGrath
9 years, 1 month ago (2011-11-21 21:57:27 UTC) #1
Markus (顧孟勤)
9 years, 1 month ago (2011-11-21 22:00:56 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698