Issue 8620009: GPU compositing on OSX canary broken

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8620009: GPU compositing on OSX canary broken (Closed)

Created:
9 years, 1 month ago by dhollowa

Modified:
9 years, 1 month ago

Reviewers:
Ken Russell (switch to Gerrit), jbates

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

GPU compositing on OSX canary broken Fixes logic for USE_AURA=1 case in Mac compositor. Changes the code to not rely on |IsOffscreen| test to determine NSView-based surface. BUG=105036 TEST=Manual test according to bug. R=jbates@chromium.org, kbr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111094

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	ui/gfx/gl/gl_context_mac.mm	View		1 chunk	+9 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

dhollowa

Hi Guys, sorry about the bustage. This fixes the problem. My faulty assumption was that ...

9 years, 1 month ago (2011-11-22 01:10:20 UTC) #1

lgtm