Issue 8620008: Get rid of Widget::ConvertPointFromAncestor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8620008: Get rid of Widget::ConvertPointFromAncestor. (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Get rid of Widget::ConvertPointFromAncestor. We don't need it now that NativeWidgetViews is dead. Also simplify View::ConvertPointToView() to look (mostly) like Layer::ConvertPointToLayer(). http://crbug.com/102573 TEST=existing unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111108

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -109 lines)			Patch
M	ui/views/widget/native_widget_aura.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	1 2 3	1 chunk	+0 lines, -7 lines	0 comments	Download
M	ui/views/widget/native_widget_gtk.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_gtk.cc	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
M	ui/views/widget/native_widget_private.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_win.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_win.cc	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
M	ui/views/widget/widget.h	View	1 2 3	1 chunk	+0 lines, -7 lines	0 comments	Download
M	ui/views/widget/widget.cc	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download
M	views/view.h	View	1 2 3	3 chunks	+10 lines, -23 lines	0 comments	Download
M	views/view.cc	View	1 2 3	3 chunks	+30 lines, -47 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8620008/8001

9 years, 1 month ago (2011-11-22 05:37:41 UTC) #3

Change committed as 111108