Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 8620004: Upstream: Make expat compiled in Android (Closed)

Created:
9 years, 1 month ago by michaelbai
Modified:
9 years, 1 month ago
CC:
chromium-reviews, John Grabowski, Peter Beverloo
Visibility:
Public.

Description

Upstream: Make expat compiled in Android BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/expat/expat.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
michaelbai
Please help to review this
9 years, 1 month ago (2011-11-21 23:30:43 UTC) #1
nsylvain
I have no idea what expat is. Is there anyone else who could review this? ...
9 years, 1 month ago (2011-11-22 00:48:36 UTC) #2
Peter Beverloo
SGTM as well. Nicolas, you reviewed the initial expat import in issue 203022, it's a ...
9 years, 1 month ago (2011-11-22 15:07:27 UTC) #3
Nico
The gyp change looks fine. I assume there's no system libexpat you could use instead?
9 years, 1 month ago (2011-11-22 15:25:42 UTC) #4
michaelbai
On 2011/11/22 15:25:42, Nico wrote: > The gyp change looks fine. I assume there's no ...
9 years, 1 month ago (2011-11-22 19:06:33 UTC) #5
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 1 month ago (2011-11-22 19:10:48 UTC) #6
Nico
LGTM
9 years, 1 month ago (2011-11-22 19:11:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/8620004/1
9 years, 1 month ago (2011-11-22 19:17:00 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 20:47:51 UTC) #9
Change committed as 111206

Powered by Google App Engine
This is Rietveld 408576698