Issue 8620002: s/Move/Stack/ in names of stacking-related methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8620002: s/Move/Stack/ in names of stacking-related methods. (Closed)

Created:
9 years, 1 month ago by Daniel Erat

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, jonathan.backer, Ian Vollick, tfarina, Paweł Hajdan Jr., piman+watch_chromium.org, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

s/Move/Stack/ in names of stacking-related methods. This renames methods in aura::Window, views::Widget, and gfx::Layer. "MoveAbove" becomes "StackAbove" and "MoveToFront" becomes "StackAtTop". BUG=none TEST=built it Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111168

Patch Set 1 #

Patch Set 2 : fix a test #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -73 lines)			Patch
M	chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/hung_renderer_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/notifications/balloon_view.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/aura/desktop.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/window.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	ui/aura/window.cc	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	1	8 chunks	+13 lines, -13 lines	0 comments	Download
M	ui/aura_shell/modal_container_layout_manager.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/aura_shell/shadow_controller.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura_shell/toplevel_window_event_filter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/compositor/layer.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	ui/gfx/compositor/layer.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/gfx/compositor/layer_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	views/view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/native_widget_aura.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_aura.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	views/widget/native_widget_gtk.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_gtk.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_private.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_win.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_win.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/widget/widget.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	views/widget/widget.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages