Issue 8620: Allow inline caching for getting the length of string wrapper objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8620: Allow inline caching for getting the length of string wrapper objects. (Closed)

Created:
12 years, 1 month ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Allow inline caching for getting the length of string wrapper objects. Committed: http://code.google.com/p/v8/source/detail?r=608

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -24 lines)			Patch
M	src/ic.cc	View	1 chunk	+11 lines, -2 lines	0 comments	Download
M	src/ic-arm.cc	View	2 chunks	+38 lines, -13 lines	1 comment	Download
M	src/objects.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/stub-cache-ia32.cc	View	1 chunk	+33 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years, 1 month ago (2008-10-27 14:41:23 UTC) #3

http://codereview.chromium.org/8620/diff/1/6
File src/ic-arm.cc (right):

http://codereview.chromium.org/8620/diff/1/6#newcode163
Line 163: Register scratch1,
This shouldn't be called scratch, since we are going to use the value later.

Expand Messages | Collapse Messages