Fix print preview control button order for views.

Fix print preview control button order for views.

BUG=104236
TEST=see bug, also chrome.toolkit is available in print preview's JS console.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113356

[Evan Stade, 2011-11-22 02:16:08]

http://codereview.chromium.org/8619009/diff/1002/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/print_preview.css (right):

http://codereview.chromium.org/8619009/diff/1002/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.css:417: -webkit-box-pack:
start;
no

[Lei Zhang, 2011-11-22 02:29:14]

http://codereview.chromium.org/8619009/diff/1002/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/print_preview.css (right):

http://codereview.chromium.org/8619009/diff/1002/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.css:417: -webkit-box-pack:
start;
On 2011/11/22 02:16:08, Evan Stade wrote:
> no

ok

[Lei Zhang, 2011-11-28 20:42:44]

ping

[Lei Zhang, 2011-12-02 19:02:18]

ping again (and how did this CL get closed?)

[Lei Zhang, 2011-12-02 22:25:53]

http://codereview.chromium.org/8619009/diff/6002/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/print_preview.css (left):

http://codereview.chromium.org/8619009/diff/6002/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.css:417:
-webkit-box-direction: reverse;
I tried putting this back as follows, without the javascript changes, and it
didn't actually reverse the buttons.

.button-strip {
-webkit-box-orient: horizontal;
-webkit-box-pack: end;
display: -webkit-box;
-webkit-box-direction: reverse;
}

In fact, -webkit-box-direction isn't used anywhere else in
chrome/browser/resources.

[Evan Stade, 2011-12-05 02:11:59]

I'll have a look at it tomorrow, that property works but I guess the rules are
flawed somewhere.

[Lei Zhang, 2011-12-06 22:40:26]

On 2011/12/05 02:11:59, Evan Stade wrote:
> I'll have a look at it tomorrow, that property works but I guess the rules are
> flawed somewhere.

Thanks for the fix. See patch set 3. Now the buttons are in the right order on
Views and non-Views. The tab order is also more 'correct': print -> cancel ->
other -> ... -> print.

[Evan Stade, 2011-12-06 23:24:33]

http://codereview.chromium.org/8619009/diff/14001/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/print_preview.css (right):

http://codereview.chromium.org/8619009/diff/14001/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/print_preview.css:421:
html[toolkit=views] .button-strip {
can't you use toolkit!=views or something

[Lei Zhang, 2011-12-06 23:29:14]

On 2011/12/06 23:24:33, Evan Stade wrote:
>
http://codereview.chromium.org/8619009/diff/14001/chrome/browser/resources/pr...
> File chrome/browser/resources/print_preview/print_preview.css (right):
> 
>
http://codereview.chromium.org/8619009/diff/14001/chrome/browser/resources/pr...
> chrome/browser/resources/print_preview/print_preview.css:421:
> html[toolkit=views] .button-strip {
> can't you use toolkit!=views or something

I did. It doesn't work. There's no != in any of the css files in
chrome/browser/resources.

[Evan Stade, 2011-12-06 23:30:19]

On 2011/12/06 23:29:14, Lei Zhang wrote:
> On 2011/12/06 23:24:33, Evan Stade wrote:
> >
>
http://codereview.chromium.org/8619009/diff/14001/chrome/browser/resources/pr...
> > File chrome/browser/resources/print_preview/print_preview.css (right):
> > 
> >
>
http://codereview.chromium.org/8619009/diff/14001/chrome/browser/resources/pr...
> > chrome/browser/resources/print_preview/print_preview.css:421:
> > html[toolkit=views] .button-strip {
> > can't you use toolkit!=views or something
> 
> I did. It doesn't work. There's no != in any of the css files in
> chrome/browser/resources.

html:not([toolkit=views])

[Lei Zhang, 2011-12-06 23:40:00]

On 2011/12/06 23:30:19, Evan Stade wrote:
> html:not([toolkit=views])

Thanks. Done.

[Evan Stade, 2011-12-07 04:37:27]

lgtm with nit

http://codereview.chromium.org/8619009/diff/14010/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/print_preview.css (right):

http://codereview.chromium.org/8619009/diff/14010/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/print_preview.css:420:
html:not([toolkit=views]) .button-strip {
prefer to group all rules that act on .button-strip itself  (i.e. put this above
the .button-strip button rule)

[Lei Zhang, 2011-12-07 04:44:12]

http://codereview.chromium.org/8619009/diff/14010/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/print_preview.css (right):

http://codereview.chromium.org/8619009/diff/14010/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/print_preview.css:420:
html:not([toolkit=views]) .button-strip {
On 2011/12/07 04:37:27, Evan Stade wrote:
> prefer to group all rules that act on .button-strip itself  (i.e. put this
above
> the .button-strip button rule)

Done.

[commit-bot: I haz the power, 2011-12-07 04:44:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8619009/21001

[commit-bot: I haz the power, 2011-12-07 06:49:15]

Change committed as 113356