Initial CL to create SDK directory (this will be done as a build step).

tools/create_sdk.py

+#!/usr/bin/env python

[Siggi Cherem (dart-lang), 2011/11/21 23:44:23]

+ copyright
+ top-level comments """
"""

[dgrove, 2011/11/22 00:41:24]

Done.

+
+import os
+import re
+import utils
+
+from os.path import dirname, join, realpath, exists, isdir
+from shutil import copyfile, copymode, copytree, ignore_patterns, rmtree
+
+HOME = dirname(dirname(realpath(__file__)))
+
+SDK = join(HOME, 'sdk')
+if exists(SDK):
+  rmtree(SDK)
+
+#
+# Create sdk/bin
+#
+
+BIN = join(SDK, 'bin')
+os.makedirs(BIN)
+
+# copy the Dart VM binary into sdk/bin

[Siggi Cherem (dart-lang), 2011/11/21 23:44:23]

Capitalize comments and end with .  (here and below)

[dgrove, 2011/11/22 00:41:24]

Done.

+build_dir = utils.GetBuildRoot(utils.GuessOS(), 'release', 'ia32') #TODO(dgrove)

[Siggi Cherem (dart-lang), 2011/11/21 23:44:23]

explain TODO, move it to its own line

[dgrove, 2011/11/22 00:41:24]

Done.

+if utils.GuessOS() == 'win32':
+  dart_src_binary = join(join(HOME, build_dir), 'dart.exe')
+  dart_dest_binary = join(BIN, 'dart.exe')
+else:
+  dart_src_binary = join(join(HOME, build_dir), 'dart')
+  dart_dest_binary = join(BIN, 'dart')
+copyfile(dart_src_binary, dart_dest_binary)
+copymode(dart_src_binary, dart_dest_binary)
+
+# create sdk/bin/frogc.dart, and hack as needed
+frog_src_dir = join(HOME, 'frog')
+
+# convert frogc.dart's imports from import('*') -> import('frog/*')
+frogc_contents = open(join(frog_src_dir, 'frogc.dart')).read()
+frogc_dest = open(join(BIN, 'frogc.dart'), 'w')
+frogc_dest.write(re.sub("#import\('", "#import('frog/", frogc_contents))
+frogc_dest.close()
+
+# TODO(dgrove): copy and fix up frog.dart
+
+# copy all files from src/frog/ to sdk/bin/frog
+frog_dest_dir = join(BIN, 'frog')
+os.makedirs(frog_dest_dir)
+
+for filename in os.listdir(frog_src_dir):
+  if filename == 'frog_options.dart':
+    # change config from 'dev' to 'sdk' in frog_options.dart
+    frog_options_contents = open(join(frog_src_dir, filename)).read()
+    frog_options_dest = open(join(frog_dest_dir, filename), 'w')
+    frog_options_dest.write(re.sub("final config = \'dev\';", 
+                                   "final config = \'sdk\';", 
+                                   frog_options_contents))
+    frog_options_dest.close()
+  elif filename.endswith('.dart'):
+    copyfile(join(frog_src_dir, filename), join(frog_dest_dir, filename))
+
+# copy frog/leg to bin/frog
+copytree(join(frog_src_dir, 'leg'), join(frog_dest_dir, 'leg'), 
+         ignore=ignore_patterns('.svn'))
+
+#
+# Create sdk/lib
+#
+
+LIB = join(SDK, 'lib')
+os.makedirs(LIB)
+
+html_src_dir = join(HOME, 'client', 'html')
+html_dest_dir = join(LIB, 'html')
+os.makedirs(html_dest_dir)
+
+dom_src_dir = join(HOME, 'client', 'dom')
+dom_dest_dir = join(LIB, 'dom')
+os.makedirs(dom_dest_dir)
+
+corelib_dest_dir = join(LIB, 'corelib')
+os.makedirs(corelib_dest_dir)
+os.makedirs(join(corelib_dest_dir, 'frog'))
+
+copyfile(join(html_src_dir, 'html.dart'), join(html_dest_dir, 'html.dart'))
+copytree(join(html_src_dir, 'src'), join(html_dest_dir, 'src'))

[Siggi Cherem (dart-lang), 2011/11/21 23:44:23]

Alternatively, we should copy html.dart from the release directory
(html/client/release), which is also what frog uses in 'dev' mode.

[dgrove, 2011/11/22 00:41:24]

Done.

+copytree(join(html_src_dir, 'generated'), join(html_dest_dir, 'generated'))
+
+for filename in os.listdir(dom_src_dir):
+  src_file = join(dom_src_dir, filename)
+  dest_file = join(dom_dest_dir, filename)
+  if filename.endswith('.dart') or filename.endswith('.js'):

[Siggi Cherem (dart-lang), 2011/11/21 23:44:23]

should we skip the monkey patching and wrapper versions?

[dgrove, 2011/11/22 00:41:24]

Done.

+    copyfile(src_file, dest_file)
+  elif isdir(src_file):
+    if filename not in ['benchmarks', 'idl', 'scripts', 'snippets', '.svn']:
+      copytree(src_file, dest_file, ignore=ignore_patterns('.svn'))
+
+
+frog_lib_src_dir = join(HOME, 'frog', 'lib')
+
+for filename in os.listdir(frog_lib_src_dir):
+  src_file = join(frog_lib_src_dir, filename)
+  dest_file = join(corelib_dest_dir, 'frog', filename)
+  if filename.endswith('.dart') or filename.endswith('.js'):
+    if filename == 'corelib.dart' or filename == 'corelib_impl.dart':
+      contents = open(src_file).read()
+      dest_file = open(dest_file, "w")
+      dest_file.write(re.sub("../../corelib/src/", "../share/", contents))

[Siggi Cherem (dart-lang), 2011/11/21 23:44:23]

I'm not convinced about having the 'share' dir, why not put them directly under
corelib/ ?

If we need a shared directory, I'd prefer 'shared' or 'common' rather than
'share'.

[dgrove, 2011/11/22 00:41:24]

I'd like to head in the direction of having a common structure for each of the
libs, where some kind of common sits in parallel with other specific
implementations. Code review is probably not the best place to explain this, so
I'll do it offline.
On 2011/11/21 23:44:23, sigmund wrote:

[Siggi Cherem (dart-lang), 2011/11/22 17:15:20]

Here is a proposal, based on what we discussed in person:

lib/
. corelib/
... *.dart  (from dart/corelib/src/*.dart)
... common/ (from dart/corelib/src/implementation/*.dart)
... frog/   (from dart/frog/lib)
. dom/
... *.dart (interfaces)
... frog/
. html/

+      dest_file.close()
+    else:
+      copyfile(src_file, dest_file)
+  elif isdir(src_file) and filename != '.svn':
+    copytree(src_file, dest_file)
+
+copytree(join(HOME, 'corelib', 'src'), join(corelib_dest_dir, 'share'), 
+         ignore=ignore_patterns('.svn'))
+
+
+# create and copy utils
+
+UTIL = join(SDK, 'utils')
+os.makedirs(UTIL)
+
+copytree(join(HOME, 'utils', 'dartdoc'), join(UTIL, 'dartdoc'), 
+         ignore=ignore_patterns('.svn'))