Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 8618013: Move accessibility_util.* from chrome/browser/chromeos to chrome/browser/chromeos/accessibility (Closed)

Created:
9 years, 1 month ago by hashimoto
Modified:
9 years, 1 month ago
Reviewers:
stevenjb, dmazzoni, satorux1
CC:
satorux1, chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Move accessibility_util.* from chrome/browser/chromeos to chrome/browser/chromeos/accessibility BUG=chromium-os:22896 TEST=build success Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111111

Patch Set 1 #

Patch Set 2 : Rebased on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -218 lines) Patch
A + chrome/browser/chromeos/accessibility/accessibility_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/accessibility/accessibility_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/accessibility_util.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/chromeos/accessibility_util.cc View 1 chunk +0 lines, -171 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/accessibility_menu_button.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/accessibility_menu_button_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/network_menu_icon.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/system_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
9 years, 1 month ago (2011-11-22 01:45:20 UTC) #1
satorux1
LGTM
9 years, 1 month ago (2011-11-22 06:07:20 UTC) #2
dmazzoni
lgtm
9 years, 1 month ago (2011-11-22 06:35:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/8618013/1
9 years, 1 month ago (2011-11-22 06:37:01 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/chrome_browser.gypi. While running patch -p1 --forward --force; patching file chrome/chrome_browser.gypi ...
9 years, 1 month ago (2011-11-22 06:37:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/8618013/5001
9 years, 1 month ago (2011-11-22 06:56:32 UTC) #6
commit-bot: I haz the power
Presubmit check for 8618013-5001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-22 06:56:39 UTC) #7
hashimoto
9 years, 1 month ago (2011-11-22 07:01:48 UTC) #8
stevenjb,
Could you review network_menu_icon.cc and ccessibility_menu_button.cc as an
OWNER?

Powered by Google App Engine
This is Rietveld 408576698