Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: vm/dart_api_impl.cc

Issue 8618011: Check for presence of native resolver in library for classes which have native fields only in reg... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/class_finalizer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart_api_impl.cc
===================================================================
--- vm/dart_api_impl.cc (revision 1726)
+++ vm/dart_api_impl.cc (working copy)
@@ -441,8 +441,13 @@
// Return error if isolate is in an inconsistent state.
// Return NULL when no error condition exists.
-static const char* CheckIsolateState(Isolate* isolate) {
- if (!ClassFinalizer::FinalizePendingClasses()) {
+static const char* CheckIsolateState(
+ Isolate* isolate,
+ bool generating_snapshot = ClassFinalizer::kNotGeneratingSnapshot) {
+ bool result = (generating_snapshot) ?
+ ClassFinalizer::FinalizePendingClassesForSnapshotCreation() :
+ ClassFinalizer::FinalizePendingClasses();
+ if (!result) {
// Make a copy of the error message as the original message string
// may get deallocated when we return back from the Dart API call.
const String& err =
@@ -2010,7 +2015,8 @@
if (snapshot_buffer == NULL || snapshot_size == NULL) {
return Api::Error("Invalid input parameters to Dart_CreateSnapshot");
}
- const char* msg = CheckIsolateState(isolate);
+ const char* msg = CheckIsolateState(isolate,
+ ClassFinalizer::kGeneratingSnapshot);
if (msg != NULL) {
return Api::Error(msg);
}
« no previous file with comments | « vm/class_finalizer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698